This repository was archived by the owner on Feb 4, 2022. It is now read-only.
fix authentication with promoteBuffers: true #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daprahamian
reviewed
May 2, 2019
Contributor
daprahamian
left a comment
daprahamian
left a comment
There was a problem hiding this comment.
Thank you for this @sebdeckers. Can you also add this to the other call to sendAuthCommand on line 213?
Contributor
Author
|
I'm not sure what you mean. Does line 202 not already address that? |
Contributor
|
ahh, nvm, looks like it is not necessary on 213. |
daprahamian
approved these changes
May 7, 2019
Contributor
|
Thank you for contributing @sebdeckers! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error when connecting to MongoDB Atlas with the option
promoteBuffers: true. Emabling that option causes the binary payload to be returned as a Node.js Buffer instance.